Default to Use starkBank.user when verifying signature.#121
Open
inglkruiz wants to merge 1 commit intostarkbank:masterfrom
Open
Default to Use starkBank.user when verifying signature.#121inglkruiz wants to merge 1 commit intostarkbank:masterfrom
inglkruiz wants to merge 1 commit intostarkbank:masterfrom
Conversation
Hi, I'm not entirely sure if this is the correct fix but while using the SDK I had an issue when consuming webhook events. It does not seem correct to set it to `null` because the user is needed for getting the public key. ```ts getPublicKey = async function (user = starkBank.user) ``` Consider the following please > JavaScript Default Parameters with null or empty Argument If we do not provide any value for the function parameter then the default value is used, but what if someone provides null or an empty string as value. In that case null and empty value is considered valid and default parameter value is not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm not entirely sure if this is the correct fix but while using the SDK I had an issue when consuming webhook events.
It does not seem correct to set it to
nullbecause the user is needed for getting the public key.Consider the following please