apollo_gateway: create large storage writer trait

[einat-starkware]

No description provided.

[einat-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_gateway: add large storage writer #11362
• apollo_gateway: create large storage writer trait #11361 👈 (View in Graphite)
• apollo_batcher: use proof manager to verify the the proofs #11157
• apollo_batcher: delete proof validator and move proof verification to transaction converter #11421
• apollo_gateway: use proof manager #11141 : 1 other dependent PR (#11147 )
• apollo_proof_manager: add proof manager client to the transaction converter #11044
• apollo_node: integrate proof manager server #11043
• apollo_node: integrate proof manager client into node #11042
• apollo_proof_manager: add metrics file #11041
• apollo_proof_manager: component request handler #11040
• apollo_proof_manager: implement component starter #11039
• apollo_proof_manager_types: create proof manager client #10965
• apollo_proof_manager: calculate hash within the proof storage #11382
• apollo_proof_manager: enable proof manager and add to deployments #11274
• apollo_proof_manager: add proof manager to node config and components #10956
• apollo_node_config: add proof manager config to node config #11242
• apollo_proof_manager: create proof manager #10943
• apollo_proof_manager: test fs proof storage #10902
• apollo_proof_manager: impl ProofStorage #10901
• apollo_proof_manager: read/write proof from file methods #10899
• apollo_proof_manager: add fs directory methods #10862
• apollo_proof_manager: add ProofStorage trait #10798
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[noaov1]

@noaov1 reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).

[noaov1]

@noaov1 made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @einat-starkware).

---

crates/apollo_gateway/src/large_storage_writer.rs line 13 at r1 (raw file):

pub trait LargeStorageWriterTrait: Send + Sync {
    async fn set_proof(&self, facts_hash: Felt, proof: Proof) -> Result<(), LargeStorageError>;
}

Suggestion:

pub trait ProofArchiveWriterTrait: Send + Sync {
    async fn set_proof(&self, facts_hash: Felt, proof: Proof) -> Result<(), LargeStorageError>;
}

---

crates/apollo_gateway/src/large_storage_writer.rs line 16 at r1 (raw file):

#[derive(Debug, Error)]
pub enum LargeStorageError {

Suggestion:

pub enum ProofArchiveError {

---

crates/apollo_gateway/src/large_storage_writer.rs line 23 at r1 (raw file):

#[derive(Clone, Default)]
// TODO(Einat): Add GCS related fields.
pub struct LargeStorageWriter;

Suggestion:

pub struct GcsProofArchiveWriter;

[einat-starkware]

@einat-starkware made 2 comments and resolved 2 discussions.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @noaov1).

---

crates/apollo_gateway/src/large_storage_writer.rs line 16 at r1 (raw file):

#[derive(Debug, Error)]
pub enum LargeStorageError {

Done.

---

crates/apollo_gateway/src/large_storage_writer.rs line 23 at r1 (raw file):

#[derive(Clone, Default)]
// TODO(Einat): Add GCS related fields.
pub struct LargeStorageWriter;

Renamed everywhere and also changed it to use proof facts instead of the hash