echonet: ignore attestation reverts

[ayeletstarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ron-starkware]

If there are any reverts of this type that happened in mainnet, then they will be shown as reverts that happened in mainnet and not in echonet. We should maybe do the same as you did in echo_center, in the transaction_sender as well.

@ron-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @matanl-starkware).

[matanl-starkware]

+1

@matanl-starkware made 2 comments.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware).

---

echonet/reports.py line 286 at r1 (raw file):

                "Attestation wrong block hash",
                lambda m: "attestation with wrong block hash" in lc(m),
            ),

Consider leaving them here (maybe with a comment). We might need them in the future, and it's also clearer that "we're aware of this Revert type, but not supposed to find any at the moment"

Code quote:

            RevertRule(
                "Attestation out of window", lambda m: "attestation is out of window" in lc(m)
            ),
            RevertRule(
                "Attestation wrong block hash",
                lambda m: "attestation with wrong block hash" in lc(m),
            ),

[ayeletstarkware]

@ayeletstarkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @matanl-starkware).

---

echonet/reports.py line 286 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Consider leaving them here (maybe with a comment). We might need them in the future, and it's also clearer that "we're aware of this Revert type, but not supposed to find any at the moment"

Done.

[ron-starkware]

@ron-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @matanl-starkware).

[matanl-starkware]

@matanl-starkware reviewed 4 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware).