Skip to content

Conversation

@AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_missing_block_header_fields branch from ab01f5b to 29fc954 Compare January 2, 2026 07:18
@avi-starkware
Copy link
Collaborator

crates/apollo_gateway/src/rpc_objects.rs line 96 at r1 (raw file):

    pub transaction_count: usize,
    pub event_count: usize,
    pub state_diff_length: usize,

The spec says these fields are u32

Code quote:

    pub transaction_count: usize,
    pub event_count: usize,
    pub state_diff_length: usize,

Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avi-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants