Merged
Conversation
oalifdal
approved these changes
Jul 15, 2025
Collaborator
oalifdal
left a comment
oalifdal
left a comment
There was a problem hiding this comment.
LGTM. Thanks @MatteoGiomi !
lifepillar
approved these changes
Jul 15, 2025
lifepillar
left a comment
lifepillar
left a comment
There was a problem hiding this comment.
Looks good to me! I'd be more drastic and replace every invalid character (I've left a suggestion).
Member
Author
|
Thanks for having a look @oalifdal, @lifepillar. I am waiting for #41 to be merged before going ahead with this one. I'll then rebase and merge it. |
MatteoGiomi
force-pushed
the
matteo/fix/so-math-in-column-names
branch
from
86f970c to
90f77df
Compare
… names in input data.
MatteoGiomi
force-pushed
the
matteo/fix/so-math-in-column-names
branch
from
90f77df to
d371ff9
Compare
Member
Author
|
Thanks a lot @oalifdal and @lifepillar for the review, I waited for #41 to be merged and then rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #43.