Merged
Conversation
Member
|
Successor of #48 implementing custom ML models as inference attack algorithms. |
MatteoGiomi
reviewed
Dec 4, 2025
MatteoGiomi
approved these changes
Dec 5, 2025
Member
MatteoGiomi
left a comment
MatteoGiomi
left a comment
There was a problem hiding this comment.
Thanks a lot @itrajanovska for this contribution, looks very good now. This feature still needs to be documented, but as discussed afk, better do it in a dedicated PR.
Contributor
Author
Thank you for your feedback @MatteoGiomi , I will merge this PR and will address the remaining comments in a separate PR. |
…ator.py; Compute risks for every group within the target column; Add an example notebook.
Create class wrappers for a KNN and the ml model; Update example inference_custom_model_example.ipynb.
Add Inference model wrappers extending InferencePredictor in inference_predictor.py; Support different number of attacks; Add tests.
itrajanovska
force-pushed
the
add_custom_inference_model
branch
from
487e2e3 to
fd4b88d
Compare
MatteoGiomi
reviewed
Dec 9, 2025
MatteoGiomi
reviewed
Dec 9, 2025
MatteoGiomi
approved these changes
Dec 9, 2025
Member
MatteoGiomi
left a comment
MatteoGiomi
left a comment
There was a problem hiding this comment.
thanks for addressing my comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a custom inference model in the inference_evaluator.py;
Add Inference model wrappers extending InferencePredictor in inference_predictor.py;
Support different number of attacks;
Add tests.