Skip to content

Conversation

@dan-tang-ssd
Copy link
Member

This PR is submitted to fix incorrect translation in modal popup.

It may be related to issue #125

@dan-tang-ssd
Copy link
Member Author

Here is the details for the issue.

When user selected a language in application, labels in the selected language can be showed correspondingly.
Only the label in popup modal is showed as English label, regardless the user selected language is Spanish or French.

I did some preliminary investigation. It looks like a known issue for filament v2 or v3 early version. It should be fixed since filament v3.2.

I checked composer.json, we are using filament v3.2.
I also checked the corresponding translation entries "Claim statement", "Claim made in the case statement" in translation.io. They have correct translation entries in both Spanish and French.


Screen shots:

English

image image

Spanish

image image

French

image image


// how to show modal popup with a bigger size?
return $form
->schema([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly make the schema return a closure as well? Not sure if this would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants