Open
Conversation
Samyoul
requested review from
3esmit,
cammellos,
corpetty,
errorists,
hesterbruikman,
michaelsbradleyjr,
oskarth and
rajeevgopalakrishna
Contributor
Author
|
Note, this PR assumes the merging of #149 |
Samyoul
changed the title
Also added references to ImageType where needed
Contributor
|
What's the state of this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed?
I've introduced the payload type of
ChatMessageIdentity. This payload type will be used to optionally broadcast user determined identity data about the user.The immediate use case of the
ChatMessageIdentityis user determined profile images and display names.Additionally the change marks
ChatMessage.ens_namefield as deprecated,ens_namewill become part of theChatMessageIdentity.Why make the change?
User's want to be able to have user determined identity. User's want the option to overwrite the default "3 word name" and identicon with a representation that they have control over.
Note
The use of
ChatMessageIdentityis 100% optional and users may choose not use any part of theChatMessageIdentityand therefore default to the "3 word name" and identicon.Also see:
epic