initial proposal for history fetching through contacts#167
initial proposal for history fetching through contacts#167iurimatias wants to merge 2 commits intomasterfrom
Conversation
| ``` | ||
|
|
||
| `HistoryResponse.message` contains the encoded original message. | ||
| A `HistoryResponse` is sent for each message in the requested time range. |
There was a problem hiding this comment.
I feel like this could be burdensome. Why not package chats into a blob and send that?
There was a problem hiding this comment.
We can potentially turn these messages into WakuMessageArchives, marshall them and send them across the wire. However, that requires individual nodes to store messages as waku messages (instead of just application messages), which means potentially they'll double every message stored (in the worst case)
There was a problem hiding this comment.
To add to this, even without message archives and bundling, I think messages have to be sent as waku messages. That means, when users switch between different capabilities, we need to think about how to handle this. Do we start/stop storing waku messages when it's turned on/off? Do we just always store waku messages, in which case turning it on/off won't be an issue because all messages always exist?
0x-r4bbit
left a comment
There was a problem hiding this comment.
Interesting idea, but it has some impact on storage that should be considered..
|
|
||
| ``` | ||
| { | ||
| "0x123": -1, // all available chat history |
There was a problem hiding this comment.
What does "all available chat history" mean here? Is this just whatever is in the local database of the contact?
|
|
||
| ## Requesting Chat history | ||
|
|
||
| The client chooses one of his online contacts at random that indicated capability to send the history for the target chat or community. |
There was a problem hiding this comment.
target chat or community
Does this mean individual contacts should be able to provide the history of an entire community?
| ``` | ||
|
|
||
| `HistoryResponse.message` contains the encoded original message. | ||
| A `HistoryResponse` is sent for each message in the requested time range. |
There was a problem hiding this comment.
We can potentially turn these messages into WakuMessageArchives, marshall them and send them across the wire. However, that requires individual nodes to store messages as waku messages (instead of just application messages), which means potentially they'll double every message stored (in the worst case)
|
|
||
| ## Requesting a community chat history | ||
|
|
||
| The client chooses one of the online contacts that displayed intentions to send chat history for the community in question. |
There was a problem hiding this comment.
In all of these scenarios, status nodes will have to store each message as waku message.
Something to take into consideration as this will have an impact on storage.
Also, it should be taking into account here in the spec that this in fact needs to happen (waku messages need to be stored separately).
There was a problem hiding this comment.
ah this ties into the fact that we should have a dont-store flag on waku-2, I think there's should be an issue somewhere about it in the vac repos
There was a problem hiding this comment.
For reference and context, the Community History Archive Protocol requires the same #164
|
@iurimatias I love this idea :-) From a UX prospective, would the following be possible:
Some random thoughts and questions:
|
|
Some further random thoughts:
|
No description provided.