Open
Conversation
0kok0
reviewed
Nov 10, 2021
|
|
||
| On the other hand, you can see the high-level diagram on the threat model to understand architectural details. | ||
|
|
||
| Our threat model is created on diagrams.net and stores on GitHub. To review our threat model, please follow the [link](https://github.com/status-im/status-security/blob/master/threat-modeling/Mobile-Wallet/DFD-wallet-L00). |
Contributor
There was a problem hiding this comment.
can we link/insert a rendered version here?
Author
There was a problem hiding this comment.
The challenge is I'm not sure about how we can keep up-to-date rendered version? Do you have any idea about that?
|
|
||
| ## Treasure Map | ||
|
|
||
| #### 1. Mobile Apps |
Contributor
There was a problem hiding this comment.
I would remove the Mobile Apps headline here, as there is nothing for Desktop yet. Also I'd add links to source and to the playstore/appstore directly
Co-authored-by: 0kok0 <61156799+0kok0@users.noreply.github.com>
Co-authored-by: 0kok0 <61156799+0kok0@users.noreply.github.com>
OxFred
approved these changes
Nov 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a new section name is "Treasure Map," and added the mobile side.
I Will add other sides when they are ready