fix: populate CopyMask in contacts other delete to fix 400 error#384
Open
rbansal42 wants to merge 1 commit intosteipete:mainfrom
Open
fix: populate CopyMask in contacts other delete to fix 400 error#384rbansal42 wants to merge 1 commit intosteipete:mainfrom
rbansal42 wants to merge 1 commit intosteipete:mainfrom
Conversation
The deleteOtherContact function called CopyOtherContactToMyContactsGroup
with an empty CopyOtherContactToMyContactsGroupRequest{}, but the Google
People API requires the CopyMask field to specify which fields to copy.
Omitting it causes a 400 badRequest error: 'copyMask is required'.
Fix by setting CopyMask to include all relevant contact fields.
Fixes steipete#383
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gog contacts other deletefails with:This makes the command completely unusable. Reported in #383.
Root Cause
In
deleteOtherContact(), theCopyOtherContactToMyContactsGroupAPI is called with an emptyCopyOtherContactToMyContactsGroupRequest{}. The Google People API requires theCopyMaskfield — without it, the API returns a 400 error.Fix
Populate
CopyMaskwith all relevant contact fields:Testing
Build passes (
go build ./...). The fix can be verified by runninggog contacts other deleteagainst anyotherContacts/resource — it should now successfully copy + delete instead of returning a 400.Fixes #383