fix(gmail): preserve --client context in watch serve push handling#411
Open
chrysb wants to merge 1 commit intosteipete:mainfrom
Open
fix(gmail): preserve --client context in watch serve push handling#411chrysb wants to merge 1 commit intosteipete:mainfrom
chrysb wants to merge 1 commit intosteipete:mainfrom
Conversation
Ensure gmail watch serve re-applies the selected OAuth client to request-time contexts before creating Gmail services, so push handling does not fall back to client default in multi-client setups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--clientoverride for request-time contexts insidegmail watch servenewServiceinGmailWatchServeCmd.Runso push handler API calls do not fall back toclient defaultTestGmailWatchServeCmd_PreservesClientOverrideForRequestContextsFixes #410.
Test plan
docker run --rm -v \"$PWD:/src\" -w /src golang:1.25 go test ./internal/cmd -run \"TestGmailWatchServeCmd_PreservesClientOverrideForRequestContexts\"gog:gog --client personal gmail watch serve ...auth required ... (client default)for non-default client path under patched binary