Update tests to not use a hard coded localhost:3000#1949
Merged
jeesunikim merged 3 commits intomainfrom Mar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Playwright E2E tests to avoid hard-coded http://localhost:3000 URLs so tests can run against a configurable port (and leverage Playwright’s baseURL support).
Changes:
- Replaced many
page.goto("http://localhost:3000/...")calls with relative navigations likepage.goto("/..."). - Introduced
BASE_URL(derived fromprocess.env.PORT) in a few tests/mocks that still construct absolute URLs. - Updated mocked storage state origin/shareable URLs to use the configurable base URL.
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/viewXdrToJsonPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/viewJsonToXdrPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/urlParams.test.ts | Uses BASE_URL for deep-link navigations with query params. |
| tests/e2e/txDashTokenSummary.test.ts | Switches navigation to relative URL. |
| tests/e2e/txDashStateChange.test.ts | Switches navigation to relative URL. |
| tests/e2e/txDashSignatures.test.ts | Switches navigation to relative URL. |
| tests/e2e/txDashResourceProfiler.test.ts | Switches navigation to relative URL. |
| tests/e2e/txDashInfo.test.ts | Switches navigation to relative URL. |
| tests/e2e/txDashFeeBreakdown.test.ts | Switches navigation to relative URL. |
| tests/e2e/txDashEvents.test.ts | Switches navigation to relative URL. |
| tests/e2e/txDashContracts.test.ts | Switches navigation to relative URL. |
| tests/e2e/txDashClassicOperations.test.ts | Switches navigation to relative URL. |
| tests/e2e/submitTransactionPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/smartContractsVersionHistory.test.ts | Switches navigation to relative URL. |
| tests/e2e/smartContractsStorage.test.ts | Switches navigation to relative URL in helper. |
| tests/e2e/smartContractsContractInfo.test.ts | Switches navigation to relative URL. |
| tests/e2e/simulateTransactionPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/signerSelector.test.ts | Uses BASE_URL when creating a new context/page for navigation. |
| tests/e2e/signTransactionPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/savedTransactions.test.ts | Switches navigation to relative URL (includes manual context usage). |
| tests/e2e/savedSmartContractIds.test.ts | Switches navigation to relative URL (includes manual context usage). |
| tests/e2e/savedRequests.test.ts | Switches navigation to relative URL (includes manual context usage). |
| tests/e2e/savedKeypairs.test.ts | Switches navigation to relative URL (includes manual context usage). |
| tests/e2e/parseMuxedAccountPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/networkSelector.test.ts | Uses relative navigation for base page and BASE_URL for deep-link case. |
| tests/e2e/networkLimitsPage.test.ts | Uses BASE_URL for one deep-link and relative URL elsewhere. |
| tests/e2e/mock/localStorage.ts | Makes storageState origin/shareable URLs depend on process.env.PORT. |
| tests/e2e/introductionPage.test.ts | Switches navigation to relative URL (includes manual context usage). |
| tests/e2e/fundAccountPage.test.ts | Switches navigation to relative URLs. |
| tests/e2e/feeBumpPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/endpointsPage.test.ts | Uses relative navigation for most pages and BASE_URL for some deep-links. |
| tests/e2e/diffXdrsPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/createMuxedAccountPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/createAccountPage.test.ts | Switches navigation to relative URL. |
| tests/e2e/buildTransaction.test.ts | Switches navigation to relative URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Preview is available here: |
leighmcculloch
approved these changes
Mar 11, 2026
Member
leighmcculloch
left a comment
leighmcculloch
left a comment
There was a problem hiding this comment.
There's one comment from Copilot that's worth looking at; otherwise it looks good to me.
quietbits
reviewed
Mar 11, 2026
|
Something went wrong with PR preview build please check |
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localhost:3000so that I can run multiple repos in parallel, make updates, and able to pass tests.