Cleanup tests #5102
Open
Cleanup tests #5102
+19
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR cleans up test code by removing redundant PARALLEL_LEDGER_APPLY configuration settings, leveraging the fact that parallel ledger application is now enabled by default and TESTDB_DEFAULT now uses file-based SQLite (BUCKET_DB_VOLATILE) which supports parallel apply.
Changes:
- Removed explicit
PARALLEL_LEDGER_APPLY = true/falsesettings that are now redundant since parallel apply is the default behavior - Simplified test setup code by removing conditionally compiled PostgreSQL-only sections
- Added SQLite test sections to run parallel apply tests with both PostgreSQL and SQLite databases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/util/test/TimerTests.cpp | Removed redundant PARALLEL_LEDGER_APPLY = true setting |
| src/herder/test/HerderTests.cpp | Removed redundant parallel apply settings, simplified test configurations, and added SQLite parallel apply test sections |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.