Skip to content

Conversation

@ThornWalli
Copy link
Contributor

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Build (pnpm build) was run locally and passed
  • Tests (pnpm test:unit and pnpm test:e2e) were run locally and passed
  • Linting (pnpm lint) was run locally and passed

Pull request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes)
  • Documentation
  • Other (please describe):

What is the current behavior?

{CF9A61F2-CFCD-4687-AD28-113B40166AE7} {9A7E369C-4000-4ECA-8D30-5E182F51C13D}

Backslashes are used in Windows, which currently cause an error.
And the configuration is imported as ts into mjs.

What is the new behavior?

The path is repaired using JSON.stringify.
And normalize the configuration file extension. Based on the source configuration.

Does this introduce a breaking change?

  • Yes
  • No

Copilot AI review requested due to automatic review settings February 9, 2026 14:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@johnjenkins
Copy link
Contributor

lgtm @ThornWalli ! Just need to run pnpm quality:fix

@johnjenkins johnjenkins merged commit b5fd792 into stenciljs:main Feb 9, 2026
3 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 9, 2026
## [1.1.8](v1.1.7...v1.1.8) (2026-02-09)

### Bug Fixes

* **bin:** added support for windows path ([#9](#9)) ([b5fd792](b5fd792))
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🎉 This PR is included in version 1.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

3 similar comments
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🎉 This PR is included in version 1.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🎉 This PR is included in version 1.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🎉 This PR is included in version 1.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ThornWalli ThornWalli deleted the feature/fix-windows-path branch February 9, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants