ACM-29227 fix search resource inflation#5558
Merged
openshift-merge-bot[bot] merged 6 commits intostolostron:mainfrom Feb 23, 2026
Merged
Conversation
KevinFCormier
force-pushed
the
ACM-29227-fix-missing-search-properties
branch
from
9a1812d to
5804e4b
Compare
KevinFCormier
changed the title
Contributor
Author
|
/test unit-tests-sonarcloud |
Contributor
Author
|
/retest |
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Generated-by: Cursor Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
KevinFCormier
force-pushed
the
ACM-29227-fix-missing-search-properties
branch
from
a91a239 to
14d356c
Compare
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Generated-by: Cursor Signed-off-by: Kevin Cormier <kcormier@redhat.com>
KevinFCormier
force-pushed
the
ACM-29227-fix-missing-search-properties
branch
from
14d356c to
0fc88e2
Compare
Contributor
Author
|
/cc @zlayne |
Contributor
Author
|
@zlayne The testing is failing because of the Sonar gate. It is complaining about the regex having 2 groups that can match empty string, but that is intentional - the |
zlayne
reviewed
Feb 19, 2026
| setIfDefined( | ||
| resource, | ||
| 'spec.domain.devices.interfaces', | ||
| parseListString(item.intefaceName)?.map((name) => ({ name })) |
zlayne
approved these changes
Feb 19, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier, zlayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/test unit-tests-sonarcloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Ticket Summary (Title):
Multicluster SDK does not support all search properties
Ticket Link:
https://issues.redhat.com/browse/ACM-29227
Type of Change:
✅ Checklist
General
ACM-12340 Fix bug with...)If Bugfix
🗒️ Notes for Reviewers
This PR adds fields for VirtualMachineInstance and fixes a bug where you could not provide null watchOptions for the useFleetSearchPoll hook.