Skip to content

[ACM-3080] Policy creation - policy not found briefly flashes on screen#5655

Merged
openshift-merge-bot[bot] merged 6 commits intostolostron:mainfrom
Ginxo:ACM-3080
Feb 10, 2026
Merged

[ACM-3080] Policy creation - policy not found briefly flashes on screen#5655
openshift-merge-bot[bot] merged 6 commits intostolostron:mainfrom
Ginxo:ACM-3080

Conversation

@Ginxo
Copy link
Contributor

@Ginxo Ginxo commented Feb 9, 2026

📝 Summary

This PR is trying to improve the UX for the create Policy feature.

  • submit button properly disabled until the new Policy is present. A new isLoading property has been added to the Wizard component from react-form-wizard package in order to control whether the submit button is enabled or not. A different approach would be to add a new Promise to mock the submit keeps processing.
  • exception use case added
  • new test file created just for this use case due to the mocks colliding

Evidences

Video_2026-02-09_12-27-11.mp4

Ticket Summary (Title):
Policy creation - policy not found briefly flashes on screen

Ticket Link:
https://issues.redhat.com/browse/ACM-3080

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Ginxo added 5 commits February 9, 2026 11:53
Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Copy link
Contributor

@Randy424 Randy424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ginxo, Randy424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ginxo
Copy link
Contributor Author

Ginxo commented Feb 10, 2026

/test unit-tests-sonarcloud

@openshift-merge-bot openshift-merge-bot bot merged commit a575fe4 into stolostron:main Feb 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants