Skip to content

ACM-30302 Fix pulllSecret quoting for disconnected vSphere/OST installation#5744

Merged
openshift-merge-bot[bot] merged 2 commits intostolostron:mainfrom
KevinFCormier:ACM-30302
Feb 24, 2026
Merged

ACM-30302 Fix pulllSecret quoting for disconnected vSphere/OST installation#5744
openshift-merge-bot[bot] merged 2 commits intostolostron:mainfrom
KevinFCormier:ACM-30302

Conversation

@KevinFCormier
Copy link
Contributor

📝 Summary

Ticket Summary (Title):
pullSecret not quoted correctly when using disconnected installation

Ticket Link:
https://issues.redhat.com/browse/ACM-30302

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Generated-by: Cursor
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
@KevinFCormier KevinFCormier changed the title Acm 30302 ACM-30302 Fix pulllSecret quoting for disconnected vSphere/OST installation Feb 23, 2026
@KevinFCormier
Copy link
Contributor Author

/cc @jeswanke

@openshift-ci openshift-ci bot requested a review from jeswanke February 24, 2026 14:30
@jeswanke
Copy link
Contributor

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeswanke, KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [KevinFCormier,jeswanke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5a471c6 into stolostron:main Feb 24, 2026
11 checks passed
@KevinFCormier
Copy link
Contributor Author

/cherry-pick release-2.16

@KevinFCormier
Copy link
Contributor Author

/cherry-pick release-2.15

@openshift-cherrypick-robot
Copy link
Contributor

@KevinFCormier: new pull request created: #5745

Details

In response to this:

/cherry-pick release-2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Contributor

@KevinFCormier: new pull request created: #5746

Details

In response to this:

/cherry-pick release-2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants