Skip to content

Comments

Refactor: HometeDomainモジュールの切り出し (Phase 1)#78

Merged
stotic-dev merged 12 commits intorefactor/multimodulesfrom
refactor/multimodules_create_phase1
Feb 18, 2026
Merged

Refactor: HometeDomainモジュールの切り出し (Phase 1)#78
stotic-dev merged 12 commits intorefactor/multimodulesfrom
refactor/multimodules_create_phase1

Conversation

@stotic-dev
Copy link
Owner

@stotic-dev stotic-dev commented Feb 17, 2026

Summary

#75 の Phase 1 対応として、HometeDomain パッケージの切り出しとLinux CI対応を実施。

  • LocalPackage/Sources/HometeDomain に Domain Models、Client Protocols、Stores を移動
  • メインターゲットに ImplDependencies/ を作成し、各 Client の liveValue 実装を配置
  • EnvironmentValues 拡張をメインターゲットの Views/Components/Environment/ に切り出し
  • Apple 専用フレームワーク(SwiftUI, MultipeerConnectivity, CryptoKit)の import を整理し、#if canImport ガードや import Observation への置換でLinuxビルドに対応
  • Linux ランナーで LocalPackage のテストを実行する GitHub Actions ワークフロー (ci_local_package.yml) を追加

Test plan

  • ローカルで swift test --package-path LocalPackage が全テストパス(45テスト)
  • CI でユニットテスト・スナップショットテストがパスすることを確認
  • CI で ci_local_package.yml ワークフローが正常に実行されることを確認
  • Xcodeでメインターゲットのビルドが通ることを確認

Closes #75

🤖 Generated with Claude Code

stotic-dev and others added 9 commits February 14, 2026 15:50
swiftlang/swiftly-actionが存在しないため、swift-actions/setup-swift@v2に差し替え。
Swift 6.2正式版を使用。

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OSAllocatedUnfairLockをconfirmationパターンに置き換え。
@mainactorスコープの同期テストなのでスレッドセーフティの保証は維持される。

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@stotic-dev-bot
Copy link
Collaborator

stotic-dev-bot commented Feb 18, 2026

Warnings
⚠️ PRの変更行が多すぎます。500行以内にしてね!理想は400行!
⚠️

homete/Views/HouseworkDetailView/SubViews/HouseworkDetailActionContent.swift#L26 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/HouseworkDetailView/SubViews/HouseworkDetailActionContent.swift#L33 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RegisterCohabitantView/SubViews/CohabitantRegistrationSession.swift#L31 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RegisterCohabitantView/SubViews/CohabitantRegistrationSession.swift#L45 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RootView/RootView.swift#L26 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RootView/RootView.swift#L32 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RootView/RootView.swift#L36 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/SettingView/SettingView.swift#L33 - TODOs should be resolved (メニューボタンタップ時の処理) (todo)

⚠️

homete/Views/SettingView/SettingView.swift#L119 - TODOs should be resolved (エラーハンドリング) (todo)

Messages
📖 Project coverage: 32.6%

HometeDomainTests: Coverage: 34.37

File Coverage
HouseworkClient.swift 63.64%
CohabitantStore.swift 76.0%
CohabitantClient.swift 90.0%
PushNotificationContent.swift 0.0% ⚠️
CohabitantMember.swift 100.0%
AccountInfoClient.swift 66.67%
AccountStore.swift 7.81%
DailyHouseworkMetaData.swift 36.36%
NonceGenerationClient.swift 27.27%
Account.swift 60.0%
AccountListenerStream.swift 60.0%
AnalyticsClient.swift 71.43%
AccountAuthStore.swift 36.49%
AnalyticsEvent.swift 0.0% ⚠️
SettingMenuItem.swift 100.0%
UserName.swift 92.86%
HouseworkItem.swift 37.25%
CohabitantPushNotificationClient.swift 75.0%
HouseworkState.swift 100.0%
CohabitantRegistrationRole.swift 0.0% ⚠️
AccountAuthInfo.swift 100.0%
CohabitantRegistrationMessage.swift 0.0% ⚠️
SignInWithAppleNonce.swift 0.0% ⚠️
HouseworkHistoryList.swift 56.25%
StoredAllHouseworkList.swift 7.89%
AccountAuthResult.swift 100.0%
CohabitantData.swift 0.0% ⚠️
ConfirmedRegistrationPeers.swift 0.0% ⚠️
SignInWithAppleResult.swift 0.0% ⚠️
HouseworkListStore.swift 5.1%
CohabitantMemberList.swift 42.11%
HouseworkIndexedDate.swift 44.44%
AccountAuthClient.swift 76.19%
SignInWithAppleClient.swift 80.0%
DomainError.swift 0.0% ⚠️
LoginContext.swift 100.0%
HouseworkBoardList.swift 94.74%
LaunchState.swift 0.0% ⚠️
DailyHouseworkList.swift 23.53%

homete.app: Coverage: 51.86

File Coverage
LaunchStateProxy.swift 50.0%
ImplAccountAuthClient.swift 33.82%
DomainErrorAlertContent.swift 66.67%
RootView.swift 67.35%
AppDependencies.swift 100.0%
ImplHouseworkClient.swift 0.0% ⚠️
ImplCohabitantClient.swift 0.0% ⚠️
CohabitantRegistrationProcessingFollowerView.swift 0.0% ⚠️
AppTabView.swift 60.31%
HouseworkItemPropertyListContent.swift 100.0%
SignInWithAppleRequestFactory.swift 0.0% ⚠️
HouseworkUtil.swift 100.0%
HouseBoardListRow.swift 100.0%
SettingView.swift 82.31%
SettingMenuItemButton.swift 94.34%
ImplCohabitantPushNotificationClient.swift 0.0% ⚠️
HouseworkDetailItemListContent.swift 100.0%
CohabitantRegistrationSession.swift 0.0% ⚠️
ImplAccountInfoClient.swift 0.0% ⚠️
SignInWithAppleResultFactory.swift 0.0% ⚠️
CohabitantRegistrationView.swift 0.0% ⚠️
ConfirmedRegistrationPeers.swift 0.0% ⚠️
CohabitantRegistrationProcessingLeader.swift 0.0% ⚠️
UserNameInputTextField.swift 96.55%
HouseworkDetailView.swift 63.27%
HouseworkDetailActionContent.swift 61.48%
HouseworkBoardView.swift 77.65%
ImplNonceGenerationClient.swift 0.0% ⚠️
RegistrationAccountView.swift 88.05%
HouseworkBoardSegmentedControl.swift 100.0%
CohabitantRegistrationProcessingView.swift 85.59%
CohabitantRegistrationPeersListView.swift 79.38%
SignInWithApple.swift 0.0% ⚠️
RegisterHouseworkView.swift 74.48%
CohabitantRegistrationScanningStateView.swift 0.0% ⚠️
LoginView.swift 65.75%
HouseworkApprovalView.swift 81.85%
SignInUpWithAppleButton.swift 11.69%
ImplSignInWithAppleClient.swift 0.0% ⚠️
HouseworkBoardListContent.swift 72.15%
ImplAnalyticsClient.swift 0.0% ⚠️
HomeView.swift 89.43%

Generated by 🚫 Danger Swift against a169a09

@stotic-dev stotic-dev changed the base branch from main to refactor/multimodules February 18, 2026 10:34
@stotic-dev stotic-dev merged commit 0d29bdd into refactor/multimodules Feb 18, 2026
5 checks passed
@stotic-dev stotic-dev deleted the refactor/multimodules_create_phase1 branch February 18, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: SPMマルチモジュール構成への移行

2 participants