Skip to content

Comments

マルチモジュール対応#79

Open
stotic-dev wants to merge 28 commits intomainfrom
refactor/multimodules
Open

マルチモジュール対応#79
stotic-dev wants to merge 28 commits intomainfrom
refactor/multimodules

Conversation

@stotic-dev
Copy link
Owner

経緯

関連Issue: #75

実装内容

確認内容

stotic-dev and others added 17 commits February 14, 2026 15:26
…ocal_package

LocalPackageの追加とMakefileにテストコマンドを追加
swiftlang/swiftly-actionが存在しないため、swift-actions/setup-swift@v2に差し替え。
Swift 6.2正式版を使用。

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OSAllocatedUnfairLockをconfirmationパターンに置き換え。
@mainactorスコープの同期テストなのでスレッドセーフティの保証は維持される。

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…hase1

Refactor: HometeDomainモジュールの切り出し (Phase 1)
@stotic-dev-bot
Copy link
Collaborator

Warnings
⚠️ PRの変更行が多すぎます。500行以内にしてね!理想は400行!
⚠️

homete/Views/HouseworkDetailView/SubViews/HouseworkDetailActionContent.swift#L26 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/HouseworkDetailView/SubViews/HouseworkDetailActionContent.swift#L33 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RegisterCohabitantView/SubViews/CohabitantRegistrationSession.swift#L31 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RegisterCohabitantView/SubViews/CohabitantRegistrationSession.swift#L45 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RootView/RootView.swift#L26 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RootView/RootView.swift#L32 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/RootView/RootView.swift#L36 - Include a single empty line between switch cases (vertical_whitespace_between_cases)

⚠️

homete/Views/SettingView/SettingView.swift#L33 - TODOs should be resolved (メニューボタンタップ時の処理) (todo)

⚠️

homete/Views/SettingView/SettingView.swift#L119 - TODOs should be resolved (エラーハンドリング) (todo)

Messages
📖 Project coverage: 22.14%

HometeDomainTests: Coverage: 34.37

File Coverage
HouseworkClient.swift 63.64%
CohabitantStore.swift 76.0%
CohabitantClient.swift 90.0%
PushNotificationContent.swift 0.0% ⚠️
CohabitantMember.swift 100.0%
AccountInfoClient.swift 66.67%
AccountStore.swift 7.81%
DailyHouseworkMetaData.swift 36.36%
NonceGenerationClient.swift 27.27%
Account.swift 60.0%
AccountListenerStream.swift 60.0%
AnalyticsClient.swift 71.43%
AccountAuthStore.swift 36.49%
AnalyticsEvent.swift 0.0% ⚠️
SettingMenuItem.swift 100.0%
UserName.swift 92.86%
HouseworkItem.swift 37.25%
CohabitantPushNotificationClient.swift 75.0%
HouseworkState.swift 100.0%
CohabitantRegistrationRole.swift 0.0% ⚠️
AccountAuthInfo.swift 100.0%
CohabitantRegistrationMessage.swift 0.0% ⚠️
SignInWithAppleNonce.swift 0.0% ⚠️
HouseworkHistoryList.swift 56.25%
StoredAllHouseworkList.swift 7.89%
AccountAuthResult.swift 100.0%
CohabitantData.swift 0.0% ⚠️
SignInWithAppleResult.swift 0.0% ⚠️
ConfirmedRegistrationPeers.swift 0.0% ⚠️
HouseworkListStore.swift 5.1%
CohabitantMemberList.swift 42.11%
AccountAuthClient.swift 76.19%
HouseworkIndexedDate.swift 44.44%
SignInWithAppleClient.swift 80.0%
DomainError.swift 0.0% ⚠️
LoginContext.swift 100.0%
HouseworkBoardList.swift 94.74%
LaunchState.swift 0.0% ⚠️
DailyHouseworkList.swift 23.53%

homete.app: Coverage: 51.82

File Coverage
LaunchStateProxy.swift 50.0%
ImplAccountAuthClient.swift 33.82%
DomainErrorAlertContent.swift 66.67%
AppDependencies.swift 100.0%
RootView.swift 67.35%
ImplHouseworkClient.swift 0.0% ⚠️
ImplCohabitantClient.swift 0.0% ⚠️
CohabitantRegistrationProcessingFollowerView.swift 0.0% ⚠️
AppTabView.swift 60.31%
HouseworkItemPropertyListContent.swift 100.0%
SignInWithAppleRequestFactory.swift 0.0% ⚠️
HouseworkUtil.swift 100.0%
HouseBoardListRow.swift 100.0%
SettingView.swift 82.31%
SettingMenuItemButton.swift 94.34%
ImplCohabitantPushNotificationClient.swift 0.0% ⚠️
HouseworkDetailItemListContent.swift 100.0%
CohabitantRegistrationSession.swift 0.0% ⚠️
ImplAccountInfoClient.swift 0.0% ⚠️
SignInWithAppleResultFactory.swift 0.0% ⚠️
CohabitantRegistrationView.swift 0.0% ⚠️
ConfirmedRegistrationPeers.swift 0.0% ⚠️
CohabitantRegistrationProcessingLeader.swift 0.0% ⚠️
UserNameInputTextField.swift 96.55%
HouseworkDetailView.swift 63.27%
HouseworkDetailActionContent.swift 61.48%
HouseworkBoardView.swift 77.65%
ImplNonceGenerationClient.swift 0.0% ⚠️
RegistrationAccountView.swift 88.05%
HouseworkBoardSegmentedControl.swift 100.0%
CohabitantRegistrationProcessingView.swift 83.78%
CohabitantRegistrationPeersListView.swift 79.38%
SignInWithApple.swift 0.0% ⚠️
RegisterHouseworkView.swift 74.48%
CohabitantRegistrationScanningStateView.swift 0.0% ⚠️
LoginView.swift 65.75%
HouseworkApprovalView.swift 81.85%
ImplSignInWithAppleClient.swift 0.0% ⚠️
ImplAnalyticsClient.swift 0.0% ⚠️
HouseworkBoardListContent.swift 72.15%
SignInUpWithAppleButton.swift 11.69%
HomeView.swift 89.43%

Generated by 🚫 Danger Swift against 0d29bdd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants