Conversation
Owner
Author
|
@phun-ky alright, so I'm back at this again during the holiday break and wondering what the performance of your styleguide is if I completely remove Polymer. Almost all major browsers support Web Components and Shadow DOM now, with Edge being the last one and it will get it as soon as it upgrades to the Chromium engine. So I'm able to just use native Shadow DOM to make this work. |
|
Actually, I removed polymer myself, and just using scoped CSS. Works like a charm for my usage. Will see if I can test that branch nevertheless. Happy new year!
null
|
Owner
Author
|
Oh nice, I didn't know browsers were still supporting that. In that case can I close #71? It was proving difficult trying to get it to work anyway. |
|
I'm not using CSS scope, I just prefix the style guide styles with: .sg (short for styleguide) and the design system have their own prefix, so styles won't cascade ;)
null
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.