This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Skip PosTransactionsOrderRule for gateway nodes #3720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeptin
reviewed
Jun 13, 2019
noescape00
force-pushed
the
gatewayintegrityRuleFix
branch
from
8b94c15 to
e7b71d3
Compare
zeptin
approved these changes
Jun 14, 2019
fassadlr
reviewed
Jun 14, 2019
| /// <exception cref="ConsensusErrors.ProofOfWorkTooHigh">Thrown in case block is a PoW block but created after the last pow height.</exception> | ||
| public override void Run(RuleContext context) | ||
| { | ||
| if (this.isGateway) |
Collaborator
There was a problem hiding this comment.
Why not just check this.Parent.ConnectionManagerSettings.IsGateway here?
Collaborator
Wrong PR sorry. |
Contributor
Author
|
Closing this PR since it was decided that integrity rules work should be reverted and re-added in the next release |
fassadlr
suggested changes
Jun 14, 2019
Collaborator
fassadlr
left a comment
fassadlr
left a comment
There was a problem hiding this comment.
Blocking until after release.
Contributor
Author
|
Recreated in #3726 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.