Merge CoinDb implementations #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeptin
reviewed
Jul 11, 2022
| this.iterator.Seek(new[] { this.table }.Concat(key).ToArray()); | ||
| } | ||
|
|
||
| public void SeekToLast() |
Collaborator
There was a problem hiding this comment.
Could you give a high-level description of how this method works? It is not entirely intuitive to me how seeking based on a single-byte table identifier gives the last record. Is it the last record within the current table? I presume it has something to do with how records are arranged below the table identifiers.
zeptin
approved these changes
Jul 12, 2022
quantumagi
added a commit
to quantumagi/StratisFullNode-1
that referenced
this pull request
Jan 30, 2023
* Merge CoinDb implementations * Reduce changes * Update db variable name * Update db variable name * Add comments to SeekToLast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leads to an overall code reduction by avoiding duplicate implementations of e.g. the Coin database. The advantage is:
LevelDb.csas an example). Also see: https://github.com/stratisproject/StratisFullNode/pull/1017/files#diff-ad3c47bdf05a759025b5f9f7136c00b1b6df571f83f96964a442bacba7604704R90-R92The abstraction interface (
IDb,IDbBatchandIDBIterator) adds other nice things such as:This has been split off PR #995 to make that PR easier to review.