Skip to content

Conversation

@plebhash
Copy link
Member

@plebhash plebhash commented Dec 24, 2025

close #147

blocker to #146

  • removes MockDownstream::next_message_from_upstream (this can be achieved with a Sniffer)
  • removes MockUpstream::next_message_from_downstream (this can be achieved with a Sniffer)
  • MockUpstream no longer "responds" to received messages
  • {MockUpstream,MockDownstream}::start return Sender<AnyMessage> (instead of Sender<MessageFrame>)
  • test_mock_upstream + test_mock_downstream unified into a single test_mock_roles to reduce redundancy

this does NOT address #148

@plebhash
Copy link
Member Author

cc @xyephy

@xyephy
Copy link
Contributor

xyephy commented Dec 24, 2025

cc @xyephy

I will have a look at it

Copy link
Contributor

@xyephy xyephy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested the PR seems to pass all tests.

@plebhash plebhash force-pushed the 2025-12-24-refactor-mock-roles branch from 599de27 to 9b4c7ca Compare January 4, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

need to standardize integration_tests_sv2::{MockDownstream, MockUpstream}::start return types

2 participants