refactor: Address feedback on bundles + minor tweaks

packages/dht/src/browser/defaultAutoCertifierClientFactory.ts → packages/dht/src/browser/createDefaultAutocertifierClient.ts

@@ -1,7 +1,7 @@
 import type { AutoCertifierClient } from '@streamr/autocertifier-client'
 import { ListeningRpcCommunicator } from '../transport/ListeningRpcCommunicator'
 
-export const defaultAutoCertifierClientFactory = (
+export const createDefaultAutocertifierClient = (
     _configFile: string,
     _autoCertifierUrl: string,
     _autoCertifierRpcCommunicator: ListeningRpcCommunicator,

packages/dht/src/connection/websocket/AutoCertifierClientFacade.ts

@@ -5,7 +5,7 @@ import {
 import { ListeningRpcCommunicator } from '../../transport/ListeningRpcCommunicator'
 import { Logger, waitForEvent } from '@streamr/utils'
 import { ITransport } from '../../transport/ITransport' 
-import { defaultAutoCertifierClientFactory } from '@/defaultAutoCertifierClientFactory'
+import { createDefaultAutocertifierClient } from '@/createDefaultAutocertifierClient'
 
 const START_TIMEOUT = 60 * 1000
 
@@ -40,7 +40,7 @@ export class AutoCertifierClientFacade {
         this.options = options
         this.rpcCommunicator = new ListeningRpcCommunicator(AUTO_CERTIFIER_SERVICE_ID, options.transport)
         this.autoCertifierClient = options.createClientFactory ? options.createClientFactory() 
-            : defaultAutoCertifierClientFactory(
+            : createDefaultAutocertifierClient(
                 options.configFile,
                 options.url,
                 this.rpcCommunicator,

packages/dht/src/nodejs/defaultAutoCertifierClientFactory.ts → packages/dht/src/nodejs/createDefaultAutocertifierClient.ts

@@ -6,7 +6,7 @@ import {
 } from '@streamr/autocertifier-client'
 import { ListeningRpcCommunicator } from '../transport/ListeningRpcCommunicator'
 
-export const defaultAutoCertifierClientFactory = (
+export const createDefaultAutocertifierClient = (
     configFile: string,
     autoCertifierUrl: string,
     autoCertifierRpcCommunicator: ListeningRpcCommunicator,

packages/utils/src/browser/crypto.ts

@@ -6,6 +6,7 @@ import {
 import aesModes from 'browserify-aes/modes'
 import { sha1 } from '@noble/hashes/legacy.js'
 import type { Transform } from 'readable-stream'
+import { utf8ToBinary } from '../binaryUtils'
 
 export function getSubtle(): SubtleCrypto {
     const { crypto } = globalThis
@@ -26,7 +27,7 @@ export function computeMd5(input: string): Buffer {
 }
 
 export function computeSha1(input: string): Buffer {
-    return Buffer.from(sha1(new TextEncoder().encode(input)))
+    return Buffer.from(sha1(utf8ToBinary(input)))
 }
 
 export type Jwk = JsonWebKey