refactor: Explicit node exports for jest (mainly)
#3344
Merged
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest prefers `node` in node test environment. Otherwise it tends to fallback to whatever caused interaction (import or require), and if `import` is es then Jest loses it.
github-actions
bot
added
test-utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
exportsfields in severalpackage.jsonfiles to explicitly add a"node"export condition for Node.js-specific builds. This improves compatibility and clarity when these packages are imported in different environments, ensuring that the correct entry points are used for Node.js.Package export improvements:
"node"export condition pointing to the Node.js CommonJS build inpackages/autocertifier-client/package.json,packages/dht/package.json, andpackages/utils/package.jsonto clarify and standardize Node.js entry points. [1] [2] [3]packages/test-utils/package.jsonto add"node"export conditions for the main entry and sub-exports (./setupCustomMatchers,./customMatchers), ensuring correct resolution in Node.js environments.