Skip to content

Conversation

@xcorail
Copy link

@xcorail xcorail commented Nov 21, 2018

Hi there!

I thought you might be interested in adding these LGTM code quality badges to your project. They indicate how you care about code quality and encourage your future contributors to do the same.
To get an idea of the analyses reflected by these grades, check the alerts discovered by LGTM.

N.B.: I am on the team behind LGTM.com, I'd appreciate your feedback on this initiative, whether you're interested or not, if you find time to drop me a line. Thanks.

@ob-stripe
Copy link
Contributor

Hi @xcorail, thanks for the PR!

LGTM looks like a great product, but we generally prefer to avoid having too many badges in our libraries' respective READMEs, so I'm going to close this without merging.

OOC, did you build your own code analysis engine, or is it built upon existing tools (e.g. Error Prone)?

@ob-stripe ob-stripe closed this Nov 21, 2018
@xcorail
Copy link
Author

xcorail commented Nov 21, 2018

Hi @ob-stripe

LGTM looks like a great product

Thanks for the feedback

OOC, did you build your own code analysis engine, or is it built upon existing tools

Yes, our code analysis engine is proprietary, not built upon or not aggregating results from other tools.
But the analysis themselves, that our engine runs, are open source at https://github.com/Semmle/ql. This way, our customers contributions are given back to the community (example)

I'm going to close this without merging

I understand your point. Note that anyways, the LGTM alerts will be always available for you, as this service is and will remain free for open source projects, so feel free to use it, and ask for help or give feedback.
By default, your repo is tentatively polled once a day, and all commits are analyzed, most recent first. But if you activate automated code review, any pull request will be analyzed immediately, and the results are reported directly in the PR comments. This is also free and a one click operation.

Cheers

@ob-stripe
Copy link
Contributor

Cool, thanks for the quick reply. I'm already in the process of writing a few PRs to fix alerts reported by LGTM, including an actual error in our Python library! 😱

Looking forward to seeing you add support for Ruby, PHP and Go :)

@xcorail
Copy link
Author

xcorail commented Nov 21, 2018

I'm already in the process of writing a few PRs to fix alerts reported by LGTM, including an actual error in our Python library!

Cool! I am glad you found it helpful 😃
Again, I can only advise to activate pull request integration to make sure that this error (or any other) never reaches your master again.

Looking forward to seeing you add support for Ruby, PHP and Go :)

Go is next on our list! Keep an eye on the community announcements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants