ci: add Rust code review instructions for Copilot#16
Conversation
Tiered review priorities focused on KV storage correctness: - Tier 1: data corruption, transaction isolation, compaction ordering - Tier 2: crash safety, WAL consistency, fsync ordering - Explicit DO NOT flag list to reduce review noise
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new file defining Rust code review instructions has been added to guide AI-assisted code review across four priority tiers: logic correctness (Tier 1), safety and crash recovery (Tier 2), API design and robustness (Tier 3), and style (Tier 4), with explicit examples and exclusion rules. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/instructions/rust.instructions.md:
- Line 52: Update the guidance at the referenced rule that currently endorses
`#[allow(clippy::...)]` with a justification so it aligns with the repo-wide
policy: replace the endorsement of `#[allow(...)]` with the preferred
`#[expect(...)]` phrasing and wording, explicitly referencing
`#[expect(clippy::...)]` as the accepted suppression pattern (and remove or
reword the `#[allow(clippy::...)]` example) to match the
`copilot-instructions.md` and `code-review.instructions.md` preference for
`#[expect(...)]`.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 213158d8-a208-44b8-a48f-50ef5d68835c
📒 Files selected for processing (1)
.github/instructions/rust.instructions.md
There was a problem hiding this comment.
Pull request overview
Adds a Rust-focused Copilot code review instruction file under .github/instructions/ to guide review prioritization and explicitly list exclusions for low-value feedback.
Changes:
- Introduces tiered review priorities (logic/correctness → safety → API/robustness → style).
- Adds an explicit “DO NOT Flag” list to reduce low-signal review comments.
- Restates scope rules, Rust-specific lint/safety expectations, and test guidance.
You can also share your feedback on Copilot code review. Take the survey.
- Tier 3 #[must_use]: reword for builder-style methods returning Self, Option, or custom types — Result already has #[must_use] - #[allow] vs #[expect]: clarify existing upstream #[allow] is acceptable, new fork code should use #[expect] - Import ordering: narrow exclusion to ordering only — unused imports ARE actionable under -D warnings
Summary
.github/instructions/rust.instructions.mdwith tiered review priorities for KV storage engine codeAdapted from the krb5-rs Rust review instructions template, with all Kerberos-specific items replaced by embedded storage engine equivalents.
Closes fjall-rs#15
Summary by CodeRabbit
Note: This update contains no user-facing changes.