Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the package publishing workflow by delegating publish responsibilities to the structured-world/repo repository. The strongswan repository now only builds packages and triggers the external publish workflow, rather than handling GPG signing, repository metadata creation, and git commits directly.
Changes:
- Replaces the
publishjob with a lightweighttrigger-repojob that calls the external publish workflow - Changes authentication from
REPO_TOKENtoSW_RELEASE_BOT_TOKENfor both workflow triggering and release creation - Passes the workflow run ID to the external publish workflow for artifact retrieval
- ensure temporary GPG keyfiles are deleted before clearing traps - log start time when waiting for publish workflow
- align rpmmacros formatting and rely on trap cleanup - match publish run by title and start time
- avoid suppressing gpg import errors - capture start time before dispatch and document timeouts
- use poll interval variables and quote outputs - rely on trap cleanup for keyfiles
- match publish run by title only and fix indentation
- prefer newest publish run and wait before polling - shred keyfile when available
- share import logic and verify rpm signatures
- define signing helper in rpm step and verify signatures - avoid pre-loop sleep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves publish responsibilities to structured-world/repo. strongswan now only builds packages, signs DEB/RPM, and triggers repo workflow via GitHub App credentials (RELEASER_APP_ID/RELEASER_APP_PRIVATE_KEY). Release creation waits for repo publish to complete.
Closes #14