[Feature] Migrate to composer create-project to generate a new project#106
[Feature] Migrate to composer create-project to generate a new project#106titouanmathis wants to merge 35 commits intodevelopfrom
composer create-project to generate a new project#106Conversation
c52e59a to
065b529
Compare
| ## Installation | ||
|
|
||
|
|
||
| Cloner le dépôt : |
There was a problem hiding this comment.
improvement add the new way to kickstart the project composer create-project ...
There was a problem hiding this comment.
The issue is that this README.md file will be the one used for the project, it should not contain instructions on how to create a project. Or maybe they could be removed on creation to avoid any confusion.
There was a problem hiding this comment.
Another idea would be to migrate the new structure to the studiometa/wordpress-project repository and to keep this repository as documentation.
There was a problem hiding this comment.
I like the idea of replacing the README after install. Kind of what we do with .env.example or wp-config-sample ?
| ); | ||
|
|
||
| runCommands( | ||
| 'Initialize Git repository', |
There was a problem hiding this comment.
issue: I don't think it's the role of this package to initialize git. Maybe we would like to create a project without git (only to test a feature locally). Moreover, it really depends on user access on repository.
suggestion: Maybe this script should be run in a manually separated script based on arguments.
There was a problem hiding this comment.
issue: I don't think it's the role of this package to initialize git. Maybe we would like to create a project without git (only to test a feature locally). Moreover, it really depends on user access on repository.
I think that initializing Git is not out of scope for this repository. We can still create test projects locally with Git, it should not have an impact on a test.
I can remove adding the origin as it is the action that could change between projects.
suggestion: Maybe this script should be run in a manually separated script based on arguments.
We might as well just do a git init command 😉
It is not used when using the `modern` target in `meta.config.js`.
Helps reduce the number of configuration files in the project's root folder.
9b29ac9 to
7036843
Compare
0591504 to
8c418a0
Compare
This PR drops usage of SAO to scaffold a new project and replace it with support for the
composer create-project studiometa/wordpress/project <project-name>command.Benefits:
This feature can be tested locally by creating a
packages.jsonfile:{ "packages": { "studiometa/create-wordpress-project": { "dev-master": { "name": "studiometa/create-wordpress-project", "version": "0.0.0", "dist": { "url": "https://github.com/studiometa/create-wordpress-project/archive/refs/heads/feature/composer-create-project.zip", "type": "zip" } } } } }And then running the following command:
The global PHP version must be set to PHP 7.3 for this command to work, you can also specify a custom PHP version:
Once the project created, you only have to go in the created directory and start
ddev:Changelog
Added
Removed
The default values should be considered as sane defaults ; the project's name is the name of the folder in which the project is create
Changed
modernwhen building assets (see studiometa/webpack-config#37)To do