Skip to content

[Bugfix] Fix the FacetsManager modifying non-main queries#50

Merged
titouanmathis merged 3 commits intodevelopfrom
bugfix/facets-main-query
Aug 19, 2025
Merged

[Bugfix] Fix the FacetsManager modifying non-main queries#50
titouanmathis merged 3 commits intodevelopfrom
bugfix/facets-main-query

Conversation

@titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Aug 19, 2025

🔗 Linked issue

#49

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR fixes a bug where the FacetsManager was adding query vars to all WP_Query instances, not just the main one.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.00%. Comparing base (a11c48a) to head (c47470f).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #50      +/-   ##
=============================================
+ Coverage      68.85%   69.00%   +0.14%     
- Complexity       222      223       +1     
=============================================
  Files             15       15              
  Lines            671      671              
=============================================
+ Hits             462      463       +1     
+ Misses           209      208       -1     
Flag Coverage Δ
unittests 69.00% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@titouanmathis titouanmathis merged commit a076c1f into develop Aug 19, 2025
11 checks passed
@titouanmathis titouanmathis mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments