Merged
Conversation
KGraphQL uses a dataloader with a timed dispatcher that loads all requested items in a single batch every 100ms. Depending on the execution time of the test query, this can include more items than anticipated by the test, so we lessen the assertion a bit to also allow _less_ than the expected loads. This commit also reverts the temporary adjustments and the extra test that were introduced to help with analyzing. Resolves #425
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 83.79% 83.79%
=======================================
Files 152 152
Lines 4936 4936
Branches 863 863
=======================================
Hits 4136 4136
Misses 497 497
Partials 303 303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bencher Report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KGraphQL uses a dataloader with a timed dispatcher that loads all requested items in a single batch every 100ms. Depending on the execution time of the test query, this can include more items than anticipated by the test, so we lessen the assertion a bit to also allow less than the expected loads.
This commit also reverts the temporary adjustments and the extra test that were introduced to help with analyzing.
Resolves #425