Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
- Coverage 97.33% 96.97% -0.36%
==========================================
Files 89 90 +1
Lines 15027 15104 +77
==========================================
+ Hits 14626 14647 +21
- Misses 401 457 +56 ☔ View full report in Codecov by Sentry. |
seanlaw
left a comment
There was a problem hiding this comment.
I did not look at the def check_fastmath function yet and I assume it is doing the right thing?
NimaSarajpoor
left a comment
There was a problem hiding this comment.
@seanlaw
I tried to make some changes according to our recent discussion. I left some comments to bring your attention to a few things.
|
@seanlaw |
Will do! Thanks for pulling this together |
|
Thanks @NimaSarajpoor. This has now been merged! |
|
@seanlaw |
See #1059
The functions with missing fastmath flags are: