This repository was archived by the owner on Aug 18, 2023. It is now read-only.
Closed
Conversation
arbourd
commented
Dec 16, 2022
Comment on lines
+67
to
+68
| path: /api/v1/health | ||
| port: 8080 |
Contributor
Author
There was a problem hiding this comment.
This might not work due to the builder only responding to the healthcheck on the TLS port when SE2_TLS_PORT is set. Is that true @cohix?
Contributor
There was a problem hiding this comment.
@arbourd I think we'll end up removing the se2-k8s template since that's for self-hosted.
Contributor
Author
There was a problem hiding this comment.
Ya this is mostly preparation for suborbital/e2core#339, so whatever e2 is using. If we remove se2-k8s we can just rebase against that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds liveness and readiness checks to the manifest templates