moves bugfix from compiled files to source files#10
Open
glebec wants to merge 1 commit intosubprotocol:masterfrom
Open
moves bugfix from compiled files to source files#10glebec wants to merge 1 commit intosubprotocol:masterfrom
glebec wants to merge 1 commit intosubprotocol:masterfrom
Conversation
YuriGor
added a commit
to YuriGor/genetic-js
that referenced
this pull request
Oct 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #8 fixed a bug but incorrectly applied the fix to the compiled
jsfolder un-minified file. The source inlibwas unaffected, meaning the minified file was also unaffected.This PR does nothing except for move that bugfix into the
lib/genetic.jsfile and re-make the finaljsfiles. Well, it also changes the unnecessary bracket syntax in the fix to dot syntax, but that is irrelevant from a functionality perspective.