Open
Conversation
1. Event “entityClicked” is triggered after clicking entity 2. selectionRadiusSquare introduced (to avoid computations in every loop) 3. Traditional loops instead of for…in (performance gain) 4. Break final loop after finding matching PinConstraint (to avoid not needed further processing)
Tabs fix
forresto
reviewed
Feb 9, 2017
| if (nearest) { | ||
| var event = new CustomEvent("entityClicked"); | ||
| event.entity = nearest; | ||
| this.dispatchEvent(event); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I found ability to react on entity click crucial for my project so I think it could be useful to contain it in default verlet-js behaviour.
I've added
entityClickedevent and also made few performance improvements innearestEntityfunction:selectionRadiusSquarecomputed at the beginning to avoid computations in every loopforinstead offor...inPinConstraintfinding (further looping is not needed)Hope you'll enjoy it
Best Regards :)