Skip to content

perf: optimize string concatenation and namespace caching #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudo-tee merged 1 commit into from
Feb 3, 2026
Merged

perf: optimize string concatenation and namespace caching #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lua/opencode/id.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ local LENGTH = 26
-- Generate random base62 string
local function random_base62(length)
local chars = '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz'
local result = ''
local parts = {}

for _ = 1, length do
for i = 1, length do
local rand = math.random(1, 62)
result = result .. chars:sub(rand, rand)
parts[i] = chars:sub(rand, rand)
end

return result
return table.concat(parts)
end

-- Convert number to hex string with padding
Expand Down Expand Up @@ -81,11 +81,12 @@ local function generate_new_id(prefix, descending)
end

-- Extract 6 bytes (48 bits) from the timestamp
local time_bytes = ''
local time_parts = {}
for i = 5, 0, -1 do
local byte_val = band(rshift(now, i * 8), 0xff)
time_bytes = time_bytes .. to_hex_padded(byte_val, 1)
time_parts[6 - i] = to_hex_padded(byte_val, 1)
end
local time_bytes = table.concat(time_parts)

-- Generate random suffix
local random_suffix = random_base62(LENGTH - 12)
Expand Down
9 changes: 6 additions & 3 deletions lua/opencode/ui/input_window.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ M._hidden = false
M._toggling = false
M._resize_scheduled = false

-- Cache namespace ID to avoid repeated creation
local placeholder_ns = vim.api.nvim_create_namespace('input_placeholder')

local function get_content_height(windows)
local line_count = vim.api.nvim_buf_line_count(windows.input_buf)
if line_count <= 0 then
Expand Down Expand Up @@ -303,7 +306,7 @@ function M.refresh_placeholder(windows, input_lines)
input_lines = vim.api.nvim_buf_get_lines(windows.input_buf, 0, -1, false)
end
if #input_lines == 1 and input_lines[1] == '' then
local ns_id = vim.api.nvim_create_namespace('input_placeholder')
local ns_id = placeholder_ns
local win_width = vim.api.nvim_win_get_width(windows.input_win)
local padding = string.rep(' ', win_width)
local slash_key = config.get_key_for_function('input_window', 'slash_commands')
Expand Down Expand Up @@ -338,15 +341,15 @@ function M.refresh_placeholder(windows, input_lines)
virt_text_pos = 'overlay',
})
else
vim.api.nvim_buf_clear_namespace(windows.input_buf, vim.api.nvim_create_namespace('input_placeholder'), 0, -1)
vim.api.nvim_buf_clear_namespace(windows.input_buf, placeholder_ns, 0, -1)
end
end

function M.clear_placeholder(windows)
if not windows or not windows.input_buf then
return
end
vim.api.nvim_buf_clear_namespace(windows.input_buf, vim.api.nvim_create_namespace('input_placeholder'), 0, -1)
vim.api.nvim_buf_clear_namespace(windows.input_buf, placeholder_ns, 0, -1)
end

function M.recover_input(windows)
Expand Down