Skip to content

fix(blink): use builtin kinds when possible#235

Merged
sudo-tee merged 1 commit intosudo-tee:mainfrom
AbaoFromCUG:main
Feb 4, 2026
Merged

fix(blink): use builtin kinds when possible#235
sudo-tee merged 1 commit intosudo-tee:mainfrom
AbaoFromCUG:main

Conversation

@AbaoFromCUG
Copy link
Contributor

  • Folder and File are builtin kind which is supported by blink.cmp, only need kind property for this case
  • Custom kind need pass kind_name and kind_icon, e.g. Subagent and 󰚩

Copilot AI review requested due to automatic review settings February 4, 2026 05:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the blink.cmp completion engine integration by properly differentiating between builtin and custom completion item kinds. Previously, all kinds were treated uniformly by setting kind and kind_icon properties. Now, the code checks if a kind (after capitalizing the first letter) exists in blink.cmp's CompletionItemKind enum and uses the appropriate properties accordingly.

Changes:

  • Added import of CompletionItemKind from blink.cmp types
  • Implemented conditional logic to use kind property for builtin kinds (File, Folder) and kind_name/kind_icon for custom kinds (Command, Context, Subagent)
  • Capitalizes the first letter of kind strings to match blink.cmp's enum naming convention

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sudo-tee
Copy link
Owner

sudo-tee commented Feb 4, 2026

Thanks for the PR

I am fine wit this change

@sudo-tee sudo-tee merged commit 6183099 into sudo-tee:main Feb 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants