fix(blink): use builtin kinds when possible#235
Merged
sudo-tee merged 1 commit intosudo-tee:mainfrom Feb 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the blink.cmp completion engine integration by properly differentiating between builtin and custom completion item kinds. Previously, all kinds were treated uniformly by setting kind and kind_icon properties. Now, the code checks if a kind (after capitalizing the first letter) exists in blink.cmp's CompletionItemKind enum and uses the appropriate properties accordingly.
Changes:
- Added import of
CompletionItemKindfrom blink.cmp types - Implemented conditional logic to use
kindproperty for builtin kinds (File, Folder) andkind_name/kind_iconfor custom kinds (Command, Context, Subagent) - Capitalizes the first letter of kind strings to match blink.cmp's enum naming convention
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks for the PR I am fine wit this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FolderandFileare builtin kind which is supported byblink.cmp, only needkindproperty for this casekind_nameandkind_icon, e.g.Subagentand