fix(ui): prevent duplicate windows by implementing buffer-to-window binding#238
Merged
fix(ui): prevent duplicate windows by implementing buffer-to-window binding#238
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new buf_fix_win module that prevents buffers from appearing in multiple windows simultaneously, addressing a limitation where winfixbuf only prevents windows from changing buffers but doesn't prevent buffers from appearing in multiple windows. The implementation uses autocmds to monitor and close duplicate windows whenever a buffer appears in more than its intended window.
Changes:
- Added a new
buf_fix_winmodule with autocmd-based window enforcement logic - Integrated buffer-to-window binding in both input and output window creation
- Added comprehensive test coverage for the new module including edge cases and autocmd behavior
- Made minor refactoring improvements to autocmds.lua for consistency
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/opencode/ui/buf_fix_win.lua | New module implementing buffer-to-window binding using autocmds to close duplicate windows |
| lua/opencode/ui/output_window.lua | Integrated buf_fix_win in buffer creation; added bufhidden and buflisted options |
| lua/opencode/ui/input_window.lua | Integrated buf_fix_win in buffer creation; added bufhidden and buflisted options |
| lua/opencode/ui/autocmds.lua | Refactored to use locally-required modules instead of inline requires; removed trailing blank line |
| tests/unit/buf_fix_win_spec.lua | Comprehensive test suite covering basic functionality, edge cases, autocmd setup behavior, and VimResized event handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0159e99 to
d98ee70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #144