Open
Conversation
Collaborator
|
Thank you. I will try to get to this next change for |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see you have already switched to
v0.11.xso you probably don't want to merge this but I still wanted to put this up for people still using the stable branch.Also the code in the
masteronly builds onv0.11.0-2and needs quite a big modification forv0.11.7(biggest is to change of the Arguments to FunctionCallbackInfo). Maybe include something like https://github.com/rvagg/nan to deal with the differences? I could probably add it although I don't write a lot of c++.