Upgrade CKEditor to 47 using sulu/sulu PR branch#326
Open
alexander-schranz wants to merge 2 commits intosulu:2.6from
Open
Upgrade CKEditor to 47 using sulu/sulu PR branch#326alexander-schranz wants to merge 2 commits intosulu:2.6from
alexander-schranz wants to merge 2 commits intosulu:2.6from
Conversation
Comment on lines
+29
to
+34
| "repositories": [ | ||
| { | ||
| "type": "vcs", | ||
| "url": "https://github.com/alexander-schranz/sulu" | ||
| } | ||
| ], |
Member
Author
There was a problem hiding this comment.
ToDo revert
Suggested change
| "repositories": [ | |
| { | |
| "type": "vcs", | |
| "url": "https://github.com/alexander-schranz/sulu" | |
| } | |
| ], |
alexander-schranz
force-pushed
the
codex/ckeditor-47-upgrade
branch
from
91bce36 to
2e820d8
Compare
4 tasks
| "scheb/2fa-trusted-device": "^7.4", | ||
| "stof/doctrine-extensions-bundle": "^1.11", | ||
| "sulu/sulu": "~2.6.21", | ||
| "sulu/sulu": "dev-codex/ckeditor-47-upgrade as 2.6.21", |
Member
Author
There was a problem hiding this comment.
revert:
Suggested change
| "sulu/sulu": "dev-codex/ckeditor-47-upgrade as 2.6.21", | |
| "sulu/sulu": "~2.6.21", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
alexander-schranz/sulu.sulu/sulubranchdev-codex/ckeditor-47-upgrade as 2.6.20.assets/admin/package.jsonto^47.0.0.public/build/admin.Why?
Align the skeleton with the CKEditor 47 upgrade from sulu/sulu#8652 and keep the admin build compatible with that Sulu branch.
BC Breaks/Deprecations
None.
To Do