Skip to content

Conversation

@ilaria-orlando
Copy link
Contributor

@ilaria-orlando ilaria-orlando commented Jan 5, 2026

Summary by Sourcery

Enhancements:

  • Refactor the user creation command to no longer extend the Symfony Command base class, preparing it for invokable usage.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the user creation console command to be an invokable handler instead of extending Symfony’s base Command class, preparing it for use with the new command bus / messenger-style invocation.

Sequence diagram for invokable CreateCommand execution via command bus

sequenceDiagram
    actor Developer
    participant Console as SymfonyConsole
    participant CommandBus
    participant CreateCommand
    participant ValidatorInterface as Validator
    participant MessageBusInterface as MessageBus

    Developer->>Console: Run app:user:create
    Console->>CommandBus: Dispatch CreateUserCommand
    CommandBus->>CreateCommand: __invoke(CreateUserCommand)
    CreateCommand->>Validator: validate(CreateUserCommand)
    Validator-->>CreateCommand: ValidationResult
    alt Validation successful
        CreateCommand->>MessageBus: dispatch(UserCreatedMessage)
        MessageBus-->>CreateCommand: Acknowledged
    else Validation failed
        CreateCommand-->>CommandBus: Throw ValidationException
    end
    CommandBus-->>Console: Return result
    Console-->>Developer: Output success or error
Loading

Class diagram for refactored CreateCommand handler

classDiagram
    class CreateCommand {
        <<invokable_handler>>
        - MessageBusInterface messageBus
        - ValidatorInterface validator
        + __construct(MessageBusInterface messageBus, ValidatorInterface validator)
        + __invoke() void
    }

    class MessageBusInterface {
    }

    class ValidatorInterface {
    }

    %% Removed inheritance from Symfony Command
    class Command {
    }

    CreateCommand ..> MessageBusInterface : uses
    CreateCommand ..> ValidatorInterface : validates
    CreateCommand ..|> Command : removed_in_PR
Loading

File-Level Changes

Change Details Files
Refactor the user creation console command to no longer extend Symfony\Component\Console\Command\Command and instead behave as a plain, invokable service-class.
  • Remove inheritance from the Symfony base Command class
  • Adjust the constructor to no longer call the parent constructor while keeping the message bus and validator dependencies as readonly properties
  • Prepare the class for use as an invokable command/service rather than a traditional console Command subclass
src/Command/User/CreateCommand.php

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ilaria-orlando ilaria-orlando merged commit fdadc17 into main Jan 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants