-
Notifications
You must be signed in to change notification settings - Fork 1
404 invokable commands #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the user creation console command to be an invokable handler instead of extending Symfony’s base Command class, preparing it for use with the new command bus / messenger-style invocation. Sequence diagram for invokable CreateCommand execution via command bussequenceDiagram
actor Developer
participant Console as SymfonyConsole
participant CommandBus
participant CreateCommand
participant ValidatorInterface as Validator
participant MessageBusInterface as MessageBus
Developer->>Console: Run app:user:create
Console->>CommandBus: Dispatch CreateUserCommand
CommandBus->>CreateCommand: __invoke(CreateUserCommand)
CreateCommand->>Validator: validate(CreateUserCommand)
Validator-->>CreateCommand: ValidationResult
alt Validation successful
CreateCommand->>MessageBus: dispatch(UserCreatedMessage)
MessageBus-->>CreateCommand: Acknowledged
else Validation failed
CreateCommand-->>CommandBus: Throw ValidationException
end
CommandBus-->>Console: Return result
Console-->>Developer: Output success or error
Class diagram for refactored CreateCommand handlerclassDiagram
class CreateCommand {
<<invokable_handler>>
- MessageBusInterface messageBus
- ValidatorInterface validator
+ __construct(MessageBusInterface messageBus, ValidatorInterface validator)
+ __invoke() void
}
class MessageBusInterface {
}
class ValidatorInterface {
}
%% Removed inheritance from Symfony Command
class Command {
}
CreateCommand ..> MessageBusInterface : uses
CreateCommand ..> ValidatorInterface : validates
CreateCommand ..|> Command : removed_in_PR
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tijsverkoyen
approved these changes
Jan 5, 2026
tijsverkoyen
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhancements: