You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm somewhat against this idea. The get function used to correspond to the HTTP method that the client makes, get() -> GET
and its the case also for all the different methods, such as post, patch and delete.
If you want this to change, then you'll need to also change every other function name, which to be honest doesn't make any sense to me.
@MostafaFawzy7 One thing I noticed, is that delete<T>() returns a Promise<T> which is not accurate at all. delete() shouldn't be returning a model, at maximum we want it to return boolean that indicates whether the operation was successful or not.
@MostafaFawzy7 One thing I noticed, is that delete<T>() returns a Promise<T> which is not accurate at all. delete() shouldn't be returning a model, at maximum we want it to return boolean that indicates whether the operation was successful or not.
I thought that we will need to return the deleted data at some cases!
No problem, let's change this as well...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed here the name of
getmethod togetAll, WTD all? @SirNarsh @HassanElZarkawy @Moamen-Elgammal @amrography @Abdallah-Abdelkhalek