Skip to content

Completed Hashing-2 problems#2149

Open
subbu4061 wants to merge 1 commit intosuper30admin:masterfrom
subbu4061:master
Open

Completed Hashing-2 problems#2149
subbu4061 wants to merge 1 commit intosuper30admin:masterfrom
subbu4061:master

Conversation

@subbu4061
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • Correct implementation of the algorithms for all three problems.
    • Good use of data structures (HashMap, HashSet) to achieve optimal time and space complexity.
    • Clear comments explaining the approach.
  • Areas for Improvement:
    • Ensure consistent indentation throughout the code for better readability.
    • Always include a newline at the end of files to adhere to standard coding practices.
    • Consider using map.getOrDefault() in the "Subarray sum equals k" solution to simplify the code, similar to the reference solution.
    • For the "Longest palindrome" solution, consider initializing the count variable with a more descriptive name like palindromeLength for better clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants