Function to decode return data if it's received by means other than as an exception when sending transaction#10
Open
sim31 wants to merge 1 commit intosuperical:mainfrom
Open
Function to decode return data if it's received by means other than as an exception when sending transaction#10sim31 wants to merge 1 commit intosuperical:mainfrom
sim31 wants to merge 1 commit intosuperical:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way it currently works is that you send a transactions using ethers and if transaction fails you provide a generated exception to this library so that it extracts and decodes an error.
I have a contract that sends custom messages ("calldata" specified by the user) to other contracts and emits return data from these calls as events. The original transaction does not revert (so no exception to decode is generated). I take return data from the emitted event and want to decode it into something meaningful.
So I added decodeReturnData to do that and extracted common code from
decodeanddecodeReturnDatato a separate function.