Skip to content

fix: the unicode doesn't work escaped#45

Merged
supervoidcoder merged 1 commit intomainfrom
fix-unicode
Jan 20, 2026
Merged

fix: the unicode doesn't work escaped#45
supervoidcoder merged 1 commit intomainfrom
fix-unicode

Conversation

@supervoidcoder
Copy link
Owner

@supervoidcoder supervoidcoder commented Jan 20, 2026

Summary by CodeRabbit

  • Style
    • Updated the ancestry tree display format to use simpler text-based characters for branch lines.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

Walkthrough

The PrintAncestry function's rendering loop now uses a plain text branch prefix "└─ " instead of the Unicode box-drawing sequence "\u2514\u2500 " for subsequent lines in the ancestry tree output.

Changes

Cohort / File(s) Summary
Display formatting
main.cpp
Changed branch prefix from Unicode escape sequence \u2514\u2500 to literal └─ characters for tree-line rendering

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny hop, a string so small,
Box-drawing chars now fade away,
Plain dashes dance through ancestry's hall,
The tree looks fresh in newfound way! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a Unicode escape sequence issue by replacing escaped Unicode characters with plain text equivalents.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@supervoidcoder
Copy link
Owner Author

@coderabbitai it wasn't just for style, when escaped it would show up as ?? instead of └─

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

Tip

For best results, initiate chat on the files or code changes.

@supervoidcoder Thank you for that clarification! You're absolutely right - this is a functional bug fix, not just a style change. The fact that escaped Unicode characters were rendering as "??" instead of the proper box-drawing characters (└─) is definitely a display issue that needed fixing.

I appreciate you providing this context. It's important to understand that using unescaped Unicode characters resolved the rendering problem.


✏️ Learnings added
Learnt from: supervoidcoder
URL: https://github.com/supervoidcoder/win-witr/pull/45

Timestamp: 2026-01-20T14:52:02.808Z
Learning: In the win-witr repository, Unicode box-drawing characters (like └─) used in the ancestry tree display must be unescaped in the code. When these characters are escaped, they render as "??" instead of displaying correctly.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

@supervoidcoder supervoidcoder merged commit 727df43 into main Jan 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant