-
Notifications
You must be signed in to change notification settings - Fork 0
Fix release notes to include all PR commits instead of only merge commit #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3adbdc4
Initial plan
Copilot 28322a7
fix: parse all PR commits instead of just merge commit in release notes
Copilot 32bc9d4
fix: address code review comments - fix array handling, add ci/style β¦
Copilot 76ed5ad
refactor: use git's built-in short hash format instead of substring
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the lipstick emoji ticks me off lolllllllllllllllllllllllllllllllllllllllllllllllllllllllllllll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai which other emojis you suggest for style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@supervoidcoder, here are some popular emoji alternatives for the Style category:Most Common Choice:
:art:- Artist Palette - This is the standard in gitmoji and widely used for formatting/style changesOther Good Options:
:broom:- Broom (your suggestion!) - Great for "cleaning up" code:paintbrush:- Paintbrush - Similar vibe to the palette:triangular_ruler:- Triangular Ruler - Emphasizes alignment/formatting:straight_ruler:- Straight Ruler - Also works for formatting:soap:- Soap - Cleaning/tidying up codeMy recommendation: Go with π¨ (artist palette) as it's the most recognized in the developer community for style/formatting commits, or stick with your π§Ή (broom) suggestion if you prefer the "cleaning up code" metaphor!
π°β¨
π§ Learnings used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok great i did the palette
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@supervoidcoderAwesome! π¨ is a solid choice β it's the standard for style/formatting changes across the dev community. Your release notes will look great!π°β¨
π§ Learnings used
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!