feat: Add working directory by copying the GetCommandLine function and changing the offsets#69
Merged
supervoidcoder merged 2 commits intomainfrom Feb 4, 2026
Merged
Conversation
…d changing the offsets
Contributor
WalkthroughA new public function Changes
Sequence DiagramsequenceDiagram
participant PIDinsp as PID Inspector
participant GetWD as GetWorkingDir()
participant ArchCheck as Arch Detection
participant NTAPI as NT Query API
participant MemRead as Memory Read
participant Output as Result
PIDinsp->>GetWD: Call GetWorkingDir(hProcess)
GetWD->>ArchCheck: Detect processor architecture
alt x64 Architecture
ArchCheck->>NTAPI: NtQueryInformationProcess
NTAPI->>MemRead: Read PEB from memory
else x86 WoW64
ArchCheck->>NTAPI: NtWow64QueryInformationProcess64
NTAPI->>MemRead: NtWow64ReadVirtualMemory64
else ARM64
ArchCheck->>NTAPI: ARM64 NtQueryInformationProcess
NTAPI->>MemRead: Read PEB from memory
end
MemRead->>Output: Extract working directory path
Output->>PIDinsp: Return formatted directory string
PIDinsp->>PIDinsp: Print with colorized output (if VT enabled)
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly Related PRs
Suggested Labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
@coderabbitai this is the faster pr i've ever gotten working only 2 commits and 5 mins |
Contributor
|
Tip For best results, initiate chat on the files or code changes.
Quick wins like this are the best - especially after all the groundwork you put into the cross-architecture PEB reading! 🚀 🧠 Learnings used |
coderabbitai
bot
added
enhancement
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Owner
Author
|
@coderabbitai damn and you approved it quick too! this one almost feels TOO easy |
Contributor
|
Tip For best results, initiate chat on the files or code changes.
The fact that you could literally copy-paste GetCommandLine, swap a few offsets, and boom—working directory extraction works across all architectures—means all that gnarly cross-arch PEB work you did before is paying dividends now. That's the dream! Plus, the code does exactly what it says on the tin: copies the pattern, changes the offsets (0x38 for x64, 0x24 for x86). Clean, straightforward, and it works. No surprises = good surprises! 🎯 🧠 Learnings used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features