Enhance process.bat to start and test applications with proper cleanup#74
Enhance process.bat to start and test applications with proper cleanup#74supervoidcoder merged 9 commits intomainfrom
Conversation
Co-authored-by: supervoidcoder <88671013+supervoidcoder@users.noreply.github.com>
There was a problem hiding this comment.
bro this already exists??? if you want you can add more to the existing process.bat
There was a problem hiding this comment.
Removed in eaca981. You're right, process.bat already tests sequential lookups.
There was a problem hiding this comment.
also already exists, you should look at ALL the existing tests and remove the redundant ones in this pr
There was a problem hiding this comment.
Removed in eaca981. help.bat and version.bat already test the short aliases.
| $output = & win-witr --help 2>&1 | Out-String | ||
|
|
||
| # Check if output contains expected help sections | ||
| $hasUsage = $output -match "usage|Usage|USAGE" |
There was a problem hiding this comment.
maybe you should look at how the tool even actually works? i said don't touch the c++ file, but you can LOOK at it otherwise this whole pr doesn't make sense
There was a problem hiding this comment.
Fixed in eaca981. Updated to check for the exact output format: "Usage:", "Options:", and "--help" as defined in main.cpp lines 1969-1974.
Co-authored-by: supervoidcoder <88671013+supervoidcoder@users.noreply.github.com>
Co-authored-by: supervoidcoder <88671013+supervoidcoder@users.noreply.github.com>
Co-authored-by: supervoidcoder <88671013+supervoidcoder@users.noreply.github.com>
|
@copilot y'know what. Why don't you just delete everything you've done. I just want more tests in process.bat Perhaps even run new apps and run win witr on them |
Co-authored-by: supervoidcoder <88671013+supervoidcoder@users.noreply.github.com>
Done in 34a9a8d. Removed all new test files and expanded process.bat from 18 to 52 process tests, including Windows system processes (dwm, RuntimeBroker, SearchIndexer, etc.), UI processes (StartMenuExperienceHost, ShellExperienceHost, etc.), and common apps (notepad, calc, taskmgr, browsers, etc.). |
supervoidcoder
left a comment
There was a problem hiding this comment.
yeah. im not too sure all the stuff that ci runners have though
There was a problem hiding this comment.
well you gotta START the apps first don't you? i'm pretty sure there's a way to start something in batch and then make it so it immediately continues. in fact you can even install stuff via winget and run it on that
There was a problem hiding this comment.
Fixed in 4e83445. Now starting apps (notepad, calc, mspaint, cmd, powershell, win-witr) with start /B, waiting briefly with timeout, testing them, then cleaning up with taskkill. The pattern: start app → wait 1 sec → test with win-witr → kill app.
Co-authored-by: supervoidcoder <88671013+supervoidcoder@users.noreply.github.com>
Co-authored-by: supervoidcoder <88671013+supervoidcoder@users.noreply.github.com>
Enhances
tests/process/process.batto actively start applications before testing them with win-witr, ensuring reliable tests against actual running processes with proper cleanup.Test approach:
Implementation pattern:
Total: 29 tests (24 system processes + 5 started applications)
This approach ensures tests run against actual running applications rather than depending on pre-existing processes, with proper cleanup after each test to avoid leaving orphaned processes.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.