fix: populate App.Platform with context property#14203
Closed
Rich-Harris wants to merge 2 commits intomainfrom
Closed
fix: populate App.Platform with context property#14203Rich-Harris wants to merge 2 commits intomainfrom
App.Platform with context property#14203Rich-Harris wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 2ab030b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
Apparently the |
Member
Author
|
Okay so it looks like the Frameworks API has completely changed since the adapter was created, and we probably need to rewrite it |
Rich-Harris
added a commit
that referenced
this pull request
Aug 13, 2025
Rich-Harris
added a commit
that referenced
this pull request
Aug 13, 2025
* add types * align config export and replace sh with bash * type errors to go with new type fixes in svelte.dev * separate syntax highlighting into a different pr * actually i guess this section was moved above? removing * add error annotation pending rewrite in #14203 --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>
Member
|
Going to close this one since we're rewriting to use the new functions and the new types in the same PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing
contextproperty toApp.Platformwhen usingadapter-netlify(so thatevent.platformis typed and gets autocomplete). For this to be truly useful we need to merge #12090 but that will have to wait for SvelteKit 3. In the meantime, this will help get the docs building on #13928